Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support WindowsDesktop project files. #2369

Closed
olivegamestudio opened this issue Jul 29, 2020 · 3 comments
Closed

Support WindowsDesktop project files. #2369

olivegamestudio opened this issue Jul 29, 2020 · 3 comments
Labels
feature
Milestone
5.5.0

Comments

@olivegamestudio
Copy link

Using GITVersion on a WindowsDesktop project file causes the following to be displayed:

WARN [07/29/20 10:29:33:69] Specified project file Sdk (Microsoft.NET.Sdk.WindowsDesktop) is not supported, please ensure the project sdk is of the following: Microsoft.NET.Sdk|Microsoft.NET.Sdk.Web.

An example WindowsDesktop project file:

<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop"> <PropertyGroup> <TargetFramework>net461</TargetFramework> <UseWPF>true</UseWPF> </PropertyGroup> </Project>
@olivegamestudio
Copy link
Author

Created pull request #2370 for this support.

@asbjornu asbjornu added this to the 5.5.0 milestone Jul 31, 2020
@asbjornu
Copy link
Member

Fixed in #2370.

@arturcic
Copy link
Member

🎉 This issue has been resolved in version 5.5.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
5.5.0
Development

No branches or pull requests
3 participants
@asbjornu @arturcic @olivegamestudio