[Bug] NoFetch property not derived from buildagent when GitVersion is invoked without arguments

[davikor]

Starting with 5.3.0 the NoFetch argument remains set false when GitVersion is being invoked without arguments. This is because the ParseArguments function checks at the beginning whether it was invoked without any arguments and then just sets some default values.

Expected Behavior

In my opinion all arguments should be set to the same value they would be set if GitVersion was invoked with at least one argument. E.g. if GitVersion is called only with parameter targetpath, NoFetch would be inferred from the buildAgent. If called without any parameters at all NoFetch would be set to false no matter what the build agents PreventFetch method says. This also applies to other parameters, e.g. the authentication would not be derived from the environment vars in case GitVersion is invoked without any arguments

Actual Behavior

Currently NoFetchremains false even if the buildagents PreventFetch function returns true when GitVersionis invoked without any arguments

Possible Fix

Remove the zero-arguments check at the beginning of the ParseArguments function. I will provide a pull request if welcome

Steps to Reproduce

invoke on a build server environment (e.g. environment variables TEAMCITY_VERSION and Git_Branch exist) one time without any arguments and the other time with unrelated argument e.g. target path and see how NoFetch is falsein the one case and true in the other.

Context

Updated from 5.2 to 5.5 and GitVersion suddenly failed because it tried to fetch data from remote

Your Environment

TeamCity 2020.1

[github-actions]

🎉 This issue has been resolved in version 5.5.1 🎉
The release is available on:

• GitHub Release
• Chocolatey Package
• .Net Global Tool

Your GitReleaseManager bot 📦🚀