Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] missing redirects #2664

Closed
matkoch opened this issue Apr 17, 2021 · 6 comments · Fixed by #2794
Closed

[Docs] missing redirects #2664

matkoch opened this issue Apr 17, 2021 · 6 comments · Fixed by #2794
Labels
documentation
Milestone
5.7.0

Comments

@matkoch
Copy link
Contributor

matkoch commented Apr 17, 2021

image
@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 21, 2021
@asbjornu
Copy link
Member

I'm not sure this particular issue still exists, but it is a huge problem that we still have a lot of duplicated information on ReadTheDocs. I would like to take it all down and just redirect everything to gitversion.net. I'm not sure how to go about doing that, though. A pull request would be highly appreciated. 🙏🏼

@stale stale bot removed the stale label Jul 21, 2021
@gep13
Copy link
Member

gep13 commented Jul 21, 2021

I have this on my list of things that I would like to get to, but that list keeps getting longer and priorities on it change ☹️

gep13 added a commit to gep13/GitVersion that referenced this issue Aug 2, 2021
@gep13
(GitTools#2664) Add redirects for pages that have moved
3319699 
As a result of changes to the structure of the documentation site, the
original 301 redirects from readthedocs, were resulting in 404's within
GitHub pages. This PR addresses this by ensuring that a Wyam
RedirectFrom attribute is added to all affected pages, so that the end
result is arrive on the correct page.

There may be additional changes that need to be made to capture all
pages, but this commit contains all 301 redirects from the current
readthedocs configuration.
@gep13 gep13 mentioned this issue Aug 2, 2021
Merged
5 tasks
arturcic pushed a commit that referenced this issue Aug 2, 2021
@gep13 @arturcic
(#2664) Add redirects for pages that have moved
60e934b 
As a result of changes to the structure of the documentation site, the
original 301 redirects from readthedocs, were resulting in 404's within
GitHub pages. This PR addresses this by ensuring that a Wyam
RedirectFrom attribute is added to all affected pages, so that the end
result is arrive on the correct page.

There may be additional changes that need to be made to capture all
pages, but this commit contains all 301 redirects from the current
readthedocs configuration.
@gep13
Copy link
Member

gep13 commented Aug 2, 2021

From the screenshot above, one of the affected URL's is:

https://gitversion.net/docs/more-info/incrementing-per-commit

If everything has worked, this link should now redirect to correct location.

@arturcic arturcic linked a pull request Aug 2, 2021 that will close this issue
(#2664) Add redirects for pages that have moved #2794
Merged
5 tasks
@gep13
Copy link
Member

gep13 commented Aug 10, 2021

@matkoch I am going to go ahead and close this out as most of the internal redirects within the site have now been taken care of.

Given the changes that have happened to the docs, and the different technologies that we have used over the years, there is a good chance that we have missed something, but these can be tackled under a different issue if any other broken links are found.

Thanks for reporting this!

@gep13 gep13 closed this as completed Aug 10, 2021
@arturcic arturcic added this to the 5.x milestone Aug 11, 2021
@arturcic arturcic modified the milestones: 5.x, 5.6.12 Aug 14, 2021
@arturcic
Copy link
Member

🎉 This issue has been resolved in version 5.7.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
5.7.0
Development

Successfully merging a pull request may close this issue.

(#2664) Add redirects for pages that have moved gep13/GitVersion
4 participants
@asbjornu @gep13 @arturcic @matkoch