Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-needed versionVariables field #2752

Closed
Evangelink opened this issue Jul 15, 2021 · 2 comments · Fixed by #2757
Closed

Un-needed versionVariables field #2752

Evangelink opened this issue Jul 15, 2021 · 2 comments · Fixed by #2757
Labels
improvement
Milestone
5.6.11

Comments

@Evangelink
Copy link
Contributor

The field versionVariables in https://github.com/GitTools/GitVersion/blob/main/src/GitVersion.MsBuild/GitVersionTaskExecutor.cs#L16 is actually never used (always written before being read) and could be refactored as local variable in the various methods.

Happy to provide a fixing PR if you approve the change.
@asbjornu
Copy link
Member

PR welcome! 🙏🏼

@Evangelink Evangelink mentioned this issue Jul 16, 2021
Merged
@asbjornu asbjornu added this to the 5.6.11 milestone Jul 16, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 5.6.11 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
5.6.11
Development

Successfully merging a pull request may close this issue.

Refactor versionVariables as local variable. Evangelink/GitVersion
2 participants
@asbjornu @Evangelink