-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Add static code analyzers #2760
Comments
That would be a nice addition. After we add the packages we'll need to fix the code to conform the styles. And then we can increase the level from warning to error |
Do you mind making a PR? Adding the packages and fixing the code? |
That's absolutely fine. I will go with the default set of rules and let you decide if there are specific you would like to enable (or disable). |
This would be great. I've started asbjornu#25 which I'm struggling to get past the tests, but please have a look at the code style I'm aiming for there so we can get compatibility between ReSharper ( |
🎉 This issue has been resolved in version 5.6.11 🎉 Your GitReleaseManager bot 📦🚀 |
I would like to suggest to install Microsoft.CodeAnalysis.NetAnalyzers to enhance code quality and also Microsoft.CodeAnalysis.CSharp.CodeStyle for styling/formatting rules.
This would help this project to increase the overall quality but also help to enforce certain code style you would like to see.
Detailed Description
Context
The first package would help to prevent certain code smells and future bugs to sneak into the codebase. The second helps to have a defined code style and could help contributors to "code" the way you prefer.
Possible Implementation
There are a lot of alternative code analyzers but these two are Microsoft actively contributed and are becoming a defacto standard in .NET5+ (can be opt-in/opt-out).
The text was updated successfully, but these errors were encountered: