Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Enable nullable on GitVersion.Core #2764

Closed
Evangelink opened this issue Jul 19, 2021 · 1 comment · Fixed by #2765
Closed

[Improvement] Enable nullable on GitVersion.Core #2764

Evangelink opened this issue Jul 19, 2021 · 1 comment · Fixed by #2765
Labels
improvement
Milestone
5.6.11

Comments

@Evangelink
Copy link
Contributor

Is your improvement request related to a problem? Please describe.

Enable the nullable functionality on GitVersion.Core project.

Detailed Description

This will help to understand (and also help analyzers) when a piece of code is expected to be always not-null or could be null.

Context

See #2763

Possible Implementation

Enable nullable on the project and fix warnings.
@Evangelink Evangelink mentioned this issue Jul 19, 2021
Merged
@asbjornu asbjornu added this to the 5.6.11 milestone Jul 22, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 5.6.11 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
5.6.11
Development

Successfully merging a pull request may close this issue.

Enable nullable feature on GitVersion.Core Evangelink/GitVersion
2 participants
@asbjornu @Evangelink