Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Self assignment in SemanticVersion.cs #2782

Closed
Evangelink opened this issue Jul 26, 2021 · 2 comments · Fixed by #2788
Closed

[Bug] Self assignment in SemanticVersion.cs #2782

Evangelink opened this issue Jul 26, 2021 · 2 comments · Fixed by #2788
Labels
bug
Milestone
5.7.0

Comments

@Evangelink
Copy link
Contributor

Describe the bug
In https://github.com/GitTools/GitVersion/blob/main/src/GitVersion.Core/VersionCalculation/SemanticVersioning/SemanticVersion.cs#L308 there is a self-assignment (i.e. property = property). The code was introduced with the bug in 2015.

Possible Fix

I would recommend to simply remove the line of code as it is useless and doesn't result from a change.
@Evangelink Evangelink added the bug label Jul 26, 2021
@arturcic arturcic added this to the 5.x milestone Jul 26, 2021
@asbjornu
Copy link
Member

I would recommend to simply remove the line of code as it is useless and doesn't result from a change.

Agreed. PR welcome. 🙏🏼

@Evangelink Evangelink mentioned this issue Jul 28, 2021
Merged
@arturcic arturcic modified the milestones: 5.x, 5.6.12 Aug 14, 2021
@arturcic
Copy link
Member

🎉 This issue has been resolved in version 5.7.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.7.0
Development

Successfully merging a pull request may close this issue.

Remove un-needed self assignment Evangelink/GitVersion
3 participants
@asbjornu @arturcic @Evangelink