Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Do not fail AppVeyor builds on force-push #2876

Closed
nils-a opened this issue Oct 12, 2021 · 3 comments · Fixed by #2877
Closed

[Feature] Do not fail AppVeyor builds on force-push #2876

nils-a opened this issue Oct 12, 2021 · 3 comments · Fixed by #2877
Labels
Milestone

Comments

@nils-a
Copy link
Contributor

nils-a commented Oct 12, 2021

I'm always frustrated when my build fails. 😁

When force-pushing (which is a nasty habit of mine) the same version as for the previous build is generated. This is fine.
However, AppVeyor builds then fail in GenerateSetVersionMessage with a (500) Internal Server Error.

Detailed Description

My guess is that this is due to the fact that the build can not be renamed to a name that has already been used.
One example of a fail is here: https://ci.appveyor.com/project/cakebuild/cake-rider/builds/41107162#L319

Context

While I really do like the feature that builds are "named" with version numbers in appVeyor, I'd rather not have the whole build fail when that does not succeed.

Possible Implementation

One possibility (fast and simple, good for me, not necessarily good for everyone) would be to try-catch the EnsureSuccessStatusCode and return a different message.

@nils-a nils-a added the feature label Oct 12, 2021
@arturcic
Copy link
Member

I agree with the solution, are you in a position to send a PR with the change?

@nils-a
Copy link
Contributor Author

nils-a commented Oct 12, 2021

Sure.

@arturcic arturcic added this to the 5.8.0 milestone Oct 12, 2021
arturcic pushed a commit that referenced this issue Oct 12, 2021
[Feature] Do not fail AppVeyor builds on force-push
@github-actions
Copy link

🎉 This issue has been resolved in version 5.8.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants