Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Unknown language detected: 'wix' #3432

Closed
RDUser-dev opened this issue Mar 9, 2023 · 8 comments
Closed

[Feature] Unknown language detected: 'wix' #3432

RDUser-dev opened this issue Mar 9, 2023 · 8 comments

Comments

@RDUser-dev
Copy link

Unable to build a Wix V4 project that uses GitVersion.MSBuild

Expected Behavior

The project should compile

Actual Behavior

Compiling generates an error "Unknown language detected: 'wix'"

Steps to Reproduce

  • Install "HeatWave for VS2022", the extension provides templates to create a new Visualstudio Wix V4 project
  • Create a new Wix V4 project by going to File>New Project>MSI Package (Wix V4)
  • From NuGet install GitVersion.MSBuild 5.12.0
  • Commit the project to a Git repository
  • Compile the project

Your Environment

  • Windows 10
  • GitVersion.MSBuild 5.12.0
  • VS Professional 2022
  • HeatWave for VS2022 (VisualStudio extension)
@RDUser-dev RDUser-dev added the bug label Mar 9, 2023
@arturcic
Copy link
Member

arturcic commented Mar 9, 2023

I would say this is more like a feature request than a bug, I will change the label

@arturcic arturcic added improvement and removed bug labels Mar 9, 2023
@arturcic arturcic changed the title [Bug] Unknown language detected: 'wix' [Feature] Unknown language detected: 'wix' Mar 9, 2023
@RDUser-dev
Copy link
Author

I would say this is more like a feature request than a bug, I will change the label

I thought build of wix projects is currently supported. But maybe I misunderstood.
@arturcic is it supported only for wix v3?
Thank you

@arturcic
Copy link
Member

arturcic commented Mar 9, 2023

Well as far as I can understand this is a new sdk project format, so we cannot support every possible new sdk projects. What I'm aware is we just define as part of MsBuild a couple of define , so I suppose custom wix project format we do not support.

To be honest in a v7 version we plan to move out ot the main core project the support for different output formats, in this case wix, and make it possible for the community to add support for any format they need, we just provide as input the version variables.

For us it's taking too much time to support every possible outputs, so we would rather offer the community the support of those outputs

@RDUser-dev
Copy link
Author

RDUser-dev commented Mar 9, 2023

Well as far as I can understand this is a new sdk project format, so we cannot support every possible new sdk projects. What I'm aware is we just define as part of MsBuild a couple of define , so I suppose custom wix project format we do not support.

I honestly didn't think it was a custom SDK format, but a standard SDK project.

this is the wixproj file

<Project Sdk="WixToolset.Sdk/4.0.0-rc.3">
  <ItemGroup>
    <PackageReference Include="GitVersion.MsBuild" Version="5.12.0">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>
  </ItemGroup>
</Project>

and this is the Package.Wxs from the generated template

<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
  <Package Name="Package2" Manufacturer="TODO Manufacturer" Version="1.0.0.0" UpgradeCode="fe4e5214-b5bc-40c4-b233-02ddbe0ac319">
    <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />

    <Feature Id="Main">
      <ComponentGroupRef Id="ExampleComponents" />
    </Feature>
  </Package>
</Wix>

To be honest in a v7 version we plan to move out ot the main core project the support for different output formats, in this case wix, and make it possible for the community to add support for any format they need, we just provide as input the version variables.

I think it's a good choice

@arturcic
Copy link
Member

arturcic commented Mar 9, 2023

Project Sdk="WixToolset.Sdk/4.0.0-rc.3">

This is what I mean by custom. It might introduce new properties/ targets that are not compatible

@RDUser-dev
Copy link
Author

OK! I got it
Thank you

@arturcic
Copy link
Member

arturcic commented Apr 7, 2023

Duplicate of #2595

@arturcic
Copy link
Member

🎉 This issue has been resolved in version 6.0.0-beta.3 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@arturcic @RDUser-dev and others