-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support to generate WiX version files #1599
Adding support to generate WiX version files #1599
Conversation
@asbjornu I have added the approval test. Could not parse command line parameter '/tmp/TestRepositories/a33c7f98-2ff5-4f0f-9ae9-34e49c184f41/log.txt'. Is this known? |
@ruhullahshah, on non-Windows operating systems, the arguments needs to use dash ( |
@asbjornu I have converted the command line arguments, from the feature specific tests, to |
@asbjornu Any plans to merge this? |
@ruhullahshah, yes, absolutely. But I'd like to get rid of all these merge commits. Do you think you can do a rebase of your PR branch against |
b192300
to
336a7f4
Compare
@asbjornu Done |
@ruhullahshah, awesome! Thanks. |
Will take up the pending work of PR (#1386) here