Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to generate WiX version files #1599

Merged
merged 5 commits into from
Feb 27, 2019

Conversation

ruhullahshah
Copy link
Contributor

Will take up the pending work of PR (#1386) here

@ruhullahshah
Copy link
Contributor Author

@asbjornu I have added the approval test.
Build on Linux & MacOS fail however. Failed to parse arguments: /tmp/TestRepositories/a33c7f98-2ff5-4f0f-9ae9-34e49c184f41/ /updatewixversionfile /l /tmp/TestRepositories/a33c7f98-2ff5-4f0f-9ae9-34e49c184f41/log.txt

Could not parse command line parameter '/tmp/TestRepositories/a33c7f98-2ff5-4f0f-9ae9-34e49c184f41/log.txt'.

Is this known?

@asbjornu
Copy link
Member

@ruhullahshah, on non-Windows operating systems, the arguments needs to use dash (-), not slash (/) since slashes are interpreted as file paths.

@ruhullahshah
Copy link
Contributor Author

ruhullahshah commented Feb 21, 2019

@asbjornu I have converted the command line arguments, from the feature specific tests, to - instead of /. However, the tests still fail on MacOS & Linux, due to other arguments that are not added by the feature specific tests. In my opinion, having a passing Windows test for this scenario is OK.

@ruhullahshah
Copy link
Contributor Author

@asbjornu Any plans to merge this?

@asbjornu
Copy link
Member

@ruhullahshah, yes, absolutely. But I'd like to get rid of all these merge commits. Do you think you can do a rebase of your PR branch against HEAD of master and then push --force?

@ruhullahshah ruhullahshah force-pushed the feature/support_for_wix_format branch from b192300 to 336a7f4 Compare February 27, 2019 11:22
@ruhullahshah
Copy link
Contributor Author

@asbjornu Done

@asbjornu asbjornu merged commit 482dfce into GitTools:master Feb 27, 2019
@asbjornu
Copy link
Member

@ruhullahshah, awesome! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants