Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: note GitVersionTask name change #2717

Merged
merged 2 commits into from
Jun 9, 2021
Merged

README.md: note GitVersionTask name change #2717

merged 2 commits into from
Jun 9, 2021

Conversation

fowl2
Copy link
Contributor

@fowl2 fowl2 commented Jun 8, 2021

follow up to #2716. Somehow it worked in the preview but not once it was committed.

follow up to #2716. Somehow it worked in the preview but not once it was committed.
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Can you please change the inline link of GitVersion task to a reference link as well? I can't suggest the change in this review, but just change this:

[GitVersionTask](https://www.nuget.org/packages/GitVersionTask/)

to this:

[GitVersionTask][gitversiontask]

And then add this to the footer:

[gitversiontask]: https://www.nuget.org/packages/GitVersionTask/

@fowl2 fowl2 requested a review from asbjornu June 9, 2021 02:47
@asbjornu asbjornu merged commit dca8008 into GitTools:main Jun 9, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2021

Thank you @fowl2 for your contribution!

@arturcic arturcic added this to the 5.6.11 milestone Jul 24, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 5.6.11 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

@fowl2 fowl2 deleted the patch-1 branch July 26, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants