Update misleading error and give resolution hints #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous message sounded like literal branches rather than Gitversion branch "types". Also gave hints on checking local repo meets Gitversion requirements or to use dynamic repositories.
asbjornu
requested changes
Jun 28, 2021
src/GitVersion.Core/Configuration/BranchConfigurationCalculator.cs
Outdated
Show resolved
Hide resolved
asbjornu
approved these changes
Jun 28, 2021
|
Thank you @DarwinJS for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2598
Previous message sounded like literal branches rather than Gitversion branch "types". Also gave hints on checking local repo meets Gitversion requirements or to use dynamic repositories.
Description
Previous message sounded like literal branches rather than Gitversion branch "types". Also gave hints on checking local repo meets Gitversion requirements or to use dynamic repositories.
Motivation and Context
The existing error message tries to use quotes to indicate these are not actual branch names - but this is easily misleading as the quotes can be taken to mean literalness rather than "Gitversion develop". The problem can also occur when the local repository clone or checkout do not follow the requirements, but the literal branches "develop" and "main" are actually present.
How Has This Been Tested?
It's just a message text change.
Screenshots (if appropriate):
Checklist: