Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2664) Add redirects for pages that have moved #2794

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Aug 2, 2021

Description

As a result of changes to the structure of the documentation site, the
original 301 redirects from readthedocs, were resulting in 404's within
GitHub pages. This PR addresses this by ensuring that a Wyam
RedirectFrom attribute is added to all affected pages, so that the end
result is arrive on the correct page.

There may be additional changes that need to be made to capture all
pages, but this commit contains all 301 redirects from the current
readthedocs configuration.

Related Issue

#2664

Motivation and Context

Attempts to address broken page links from Google Searches, as well as any existing saved URL's to old readthedocs pages.

How Has This Been Tested?

Went through each page during live stream on Twitch, using the preview-documentation Cake Task. Witnessed by @arturcic who was present on the stream 😄

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

As a result of changes to the structure of the documentation site, the
original 301 redirects from readthedocs, were resulting in 404's within
GitHub pages. This PR addresses this by ensuring that a Wyam
RedirectFrom attribute is added to all affected pages, so that the end
result is arrive on the correct page.

There may be additional changes that need to be made to capture all
pages, but this commit contains all 301 redirects from the current
readthedocs configuration.
@gep13 gep13 requested review from asbjornu and arturcic August 2, 2021 20:32
@arturcic arturcic merged commit 60e934b into GitTools:main Aug 2, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2021

Thank you @gep13 for your contribution!

@arturcic arturcic linked an issue Aug 2, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] missing redirects
2 participants