Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve site level redirects #2577

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

taranvohra
Copy link
Member

@taranvohra taranvohra commented Nov 21, 2024

This PR adds support for resolving site redirects configured on a site. The order is as follows

  • First site content is always resolved to its canonical URL
  • Then we lookup the page using the pathname
    a. If we find the page, good enough
    b. If we don't find the page we check if there is a redirect at content (space) level
    c. If we still don't find the page we check if there is a redirect at site level

Between (b) & (c), I suggest we do (b) first because content level redirects existed before.

Copy link

linear bot commented Nov 21, 2024

Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: ee7c0ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 21, 2024

GitBook Preview
Latest commit: https://5128417d.gitbook-open.pages.dev
PR: https://pr2577.gitbook-open.pages.dev

Copy link

argos-ci bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 19 changed, 4 added Nov 21, 2024, 2:43 PM

@taranvohra taranvohra marked this pull request as ready for review November 21, 2024 14:53
@taranvohra taranvohra merged commit 99b6c92 into main Nov 22, 2024
9 checks passed
@taranvohra taranvohra deleted the taran/rnd-5565-resolve-redirects-in-gitbook-open branch November 22, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants