Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QF rounds should be sorted by date, where the one closest to the right is the most recent #4289

Open
laurenluz opened this issue Jun 17, 2024 · 5 comments · May be fixed by #4390
Open

QF rounds should be sorted by date, where the one closest to the right is the most recent #4289

laurenluz opened this issue Jun 17, 2024 · 5 comments · May be fixed by #4390
Assignees
@HrithikSampson @CarlosQ96 @maryjaf
Labels
P0 Something is broken or not working QF Quadratic Funding Related

Comments

@laurenluz
Copy link
Member

I was looking at glo dollar and realized that our QF rounds are sorted in a really weird way... maybe alphabetically?

The qf round "tabs" on the donations tab for a project on the project single page should be sorted from left to right according to most recent.

so you should see here Galactic Giving, Giving Season, Optimism, for example

image

@CarlosQ96 or @MohammadPCh can you assign the right frontend dev for this?

cc @koday1
@laurenluz laurenluz added the P0 Something is broken or not working label Jun 17, 2024
@Udit-takkar Udit-takkar linked a pull request Jul 6, 2024 that will close this issue
Open
@divine-comedian divine-comedian added the QF Quadratic Funding Related label Jul 8, 2024
@divine-comedian divine-comedian moved this to Product Backlog in All-Devs Aug 2, 2024
@koday1
Copy link
Collaborator

koday1 commented Aug 6, 2024 •
edited
Loading

Hey @Meriem-BM just reviving this issue - could you take a look at how we're sorting QF rounds under the 'Donations' tab on project pages and see if we can easily adjust to sorting chronologically?

@jainkrati jainkrati assigned CarlosQ96 and unassigned Meriem-BM Sep 5, 2024
@divine-comedian
Copy link
Contributor

@HrithikSampson do you mind taking a look at this one w/ guidance from @CarlosQ96

@HrithikSampson
Copy link
Collaborator

Sure @divine-comedian . I will thake this issue

@HrithikSampson HrithikSampson mentioned this issue Oct 3, 2024
Merged
@HrithikSampson HrithikSampson moved this from Product Backlog to Code Review/PR in All-Devs Oct 3, 2024
@HrithikSampson
Copy link
Collaborator

@maryjaf @LatifatAbdullahi , this issue is ready to be tested

@HrithikSampson HrithikSampson moved this from Code Review/PR to QA in All-Devs Oct 4, 2024
@maryjaf maryjaf self-assigned this Oct 6, 2024
@maryjaf
Copy link
Collaborator

maryjaf commented Oct 6, 2024

The tests have been passed, thanks @HrithikSampson

@maryjaf maryjaf moved this from QA to Done in All-Devs Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HrithikSampson HrithikSampson

@CarlosQ96 CarlosQ96

@maryjaf maryjaf

Labels
P0 Something is broken or not working QF Quadratic Funding Related
Projects
All-Devs
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: sort by date Udit-takkar/giveth-dapps-v2
7 participants
@koday1 @HrithikSampson @Meriem-BM @divine-comedian @laurenluz @CarlosQ96 @maryjaf