Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[philips-hue] Newly bridge paired lamp cannot be used in Gladys #1006

Closed
VonOx opened this issue Dec 7, 2020 · 14 comments
Closed

[philips-hue] Newly bridge paired lamp cannot be used in Gladys #1006

VonOx opened this issue Dec 7, 2020 · 14 comments

Comments

@VonOx
Copy link
Contributor

VonOx commented Dec 7, 2020

This is a first analyse.

On existing hue / Gladys installation, if I add new lamp in hue bridge and in Gladys, I can't use them before restart.

https://community.gladysassistant.com/t/probleme-avec-hue-et-lumiere-bloom

@Pierre-Gilles
Copy link
Contributor

@VonOx So the fix is upgrading the philips hue node library?

@VonOx
Copy link
Contributor Author

VonOx commented Dec 11, 2020

Nope, just restarting container

@Pierre-Gilles
Copy link
Contributor

I don't understand, what was the bug then? Restarting a container is not a solution ^^

It should work all the time, no restart needed

@VonOx
Copy link
Contributor Author

VonOx commented Dec 11, 2020

I agree, that's why I opened issue

@VonOx
Copy link
Contributor Author

VonOx commented May 7, 2021

Opened an issue on lib repo

peter-murray/node-hue-api#197

@VonOx
Copy link
Contributor Author

VonOx commented Oct 4, 2021

https://github.com/peter-murray/node-hue-api/blob/4.x/lib/api/Api.js#L154

@Pierre-Gilles in that case we can call resynch function.

As lib maintainer says to me, it's an heavy call so what's the plan here ?

  • In case of error we resync
    or
  • On demand via UI button

@Pierre-Gilles
Copy link
Contributor

If the error easy to identify ? If yes, on error why not, but the problem is that we really don't want to trigger this multiple time in a row as it's an heavy call!

Or maybe, when adding a new lamp, could we know if the problem is here?

@VonOx
Copy link
Contributor Author

VonOx commented Oct 9, 2021

Yep error is pretty clear in this issue

ApiError: Light with id:12 was not found on this bridge

But i did'nt know how to catch them.

Error is triggered when contrlling the device not when adding them to Gladys

@Pierre-Gilles
Copy link
Contributor

ApiError: Light with id:12 was not found on this bridge

Yes, but this error could also be "normal", for example if the user added a lamp in Gladys, then remove the lamp from Philips Hue. In that case, we will be retrying many time and it won't solve the issue.

Maybe the best would be to do a combo:

  • Message in the UI if the error occured recently ? We can save a flag in the JS code of the Philips Hue integration
  • Button in the UI (always displayed) to re-sync the bridge, with a confirmation to warn the user that this is a heavy call

What do you think of that ?

@stale
Copy link

stale bot commented Dec 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 9, 2021
@VonOx
Copy link
Contributor Author

VonOx commented Dec 9, 2021

Not stale

@stale stale bot removed the stale label Dec 9, 2021
@stale
Copy link

stale bot commented Feb 7, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 7, 2022
@Pierre-Gilles
Copy link
Contributor

Not stale

@stale stale bot removed the stale label Feb 11, 2022
@stale
Copy link

stale bot commented Apr 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 12, 2022
@stale stale bot closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants