Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove datasets requiring access key #321

Open
askarbozcan opened this issue Aug 14, 2022 · 1 comment
Open

Remove datasets requiring access key #321

askarbozcan opened this issue Aug 14, 2022 · 1 comment
Assignees
@askarbozcan
Labels
cleanup Issues/PRs part of cleanup dataset

Comments

@askarbozcan
Copy link
Member

Most of datasets are hosted on S3, requiring access key and secret code making them inaccessible for pretty much all users.
ALL data if provided as part of Sadedegel should be open.
Issues with "private" datasets are as such:

  1. Part of Sadedegel becomes inaccessible as most users won't bother asking for the secret code.
  2. Sadedegel is a library first and this part should be emphasized.
@askarbozcan askarbozcan added dataset cleanup-stay Issues that won't be removed as part of cleanup cleanup Issues/PRs part of cleanup and removed cleanup-stay Issues that won't be removed as part of cleanup labels Aug 14, 2022
@askarbozcan askarbozcan self-assigned this Aug 14, 2022
@dafajon
Copy link
Contributor

dafajon commented Aug 16, 2022 •
edited
Loading

I addressed that on this PR.
#315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@askarbozcan askarbozcan

Labels
cleanup Issues/PRs part of cleanup dataset
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dafajon @askarbozcan