We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
Existing image name and tag in settings.json are overwritten by values from gluu_versions.json.
settings.json
gluu_versions.json
To Reproduce
Steps to reproduce the behavior:
pygluu-kubernetes generate-settings
Y
LDAP image tag
4.2.1_dev
pygluu-kubernetes install
LDAP_IMAGE_TAG
Expected behavior
The value of LDAP_IMAGE_TAG should be 4.2.1_dev as entered when running generate-settings for the first time.
generate-settings
Additional context
Reading from source code, this line is problematic:
self.settings.update(image_names_and_tags)
as it will (eventually) overwrite existing keys in settings.json.
The text was updated successfully, but these errors were encountered:
We can add check for non-empty image name and tag before merging values from gluu_versions.json into settings, for example:
self.settings.update({ k: v for k, v in image_names_and_tags.items() if not self.settings.get(k, "") })
Sorry, something went wrong.
iromli
moabu
Successfully merging a pull request may close this issue.
Describe the bug
Existing image name and tag in
settings.json
are overwritten by values fromgluu_versions.json
.To Reproduce
Steps to reproduce the behavior:
pygluu-kubernetes generate-settings
Y
LDAP image tag
to4.2.1_dev
pygluu-kubernetes generate-settings
orpygluu-kubernetes install
(no prompts appear)LDAP_IMAGE_TAG
insettings.json
Expected behavior
The value of
LDAP_IMAGE_TAG
should be4.2.1_dev
as entered when runninggenerate-settings
for the first time.Additional context
Reading from source code, this line is problematic:
as it will (eventually) overwrite existing keys in
settings.json
.The text was updated successfully, but these errors were encountered: