Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oxauth-key-rotation): add schedule property #654

Merged
merged 4 commits into from
Aug 27, 2024
Merged

feat(oxauth-key-rotation): add schedule property #654

merged 4 commits into from
Aug 27, 2024

Conversation

misba7
Copy link
Contributor

@misba7 misba7 commented Aug 27, 2024

closes #653

@misba7 misba7 requested a review from iromli August 27, 2024 14:30
@misba7 misba7 self-assigned this Aug 27, 2024
iromli
iromli requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@iromli iromli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the same attribute to oxauth-key-rotation values.yaml

iromli
iromli requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@iromli iromli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generate Helm docs to accommodate the changes

@iromli iromli merged commit 87fedbc into 4.5 Aug 27, 2024
3 of 10 checks passed
@iromli iromli deleted the feat-cn-rotation-schedule branch August 27, 2024 15:57
This was referenced Aug 27, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iromli iromli iromli approved these changes

Assignees

@misba7 misba7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: override oxauth-key-rotation spec.schedule value
2 participants
@misba7 @iromli