Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compiler flags instead of feature for nightly features #7

Open
ranile opened this issue Dec 13, 2024 · 1 comment
Open

Use compiler flags instead of feature for nightly features #7

ranile opened this issue Dec 13, 2024 · 1 comment

Comments

@ranile
Copy link

ranile commented Dec 13, 2024

See yewstack/yew#2754 for rationale. Tokio also uses the same approach with tokio_unstable feature

This will allow downstream users, who use cfg for nightly features, to enable nightly features of proc-macro-error2) by using build.rs to set the flag). It's currently impossible to do this: yewstack/yew#3752

@Alextopher
Copy link

@ranile what do you think about #5 where proc-macro-error2 has the build script that sets the relevant flags?

I've left that PR fall off my plate but all it is missing is CI I can try to push over the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants