Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRToolsInteractableAreaButton animation ignore node process mode and is always pausable #657

Open
GaelFG-Anderon opened this issue Jul 12, 2024 · 0 comments

Comments

@GaelFG-Anderon
Copy link

I use XRToolsInteractableAreaButton on my pause menu and it occured XRToolsInteractableAreaButton don't animate if the scene tree is paused even if the node process mode is set to always.

It's because the animation tweens are created with

	# Construct the button animation tween
	_tween = get_tree().create_tween()
	_tween.set_trans(Tween.TRANS_LINEAR)
	_tween.set_ease(Tween.EASE_IN_OUT)
	_tween.tween_property(_button, "position", _button_down, duration)

I corrected it by adding :

 _tween.bind_node(self)
_tween.set_pause_mode(Tween.TWEEN_PAUSE_BOUND)

in the animation code on the two places before the call to "tween_property".

I'm not sure it doesn't have unseen side effect or if it is desirable for everyone, but I can submit a pull request with the change if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant