Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress tracing while tracing #45

Open
kuzuk opened this issue Sep 27, 2017 · 1 comment
Open

Suppress tracing while tracing #45

kuzuk opened this issue Sep 27, 2017 · 1 comment
Labels
Milestone

Comments

@kuzuk
Copy link

kuzuk commented Sep 27, 2017

Feature request: in the code handling tracers, suppress 'tracing while tracing'. That is: tracing instrumentation triggered while already tracing should not be followed on.

E.g. when entering a method, toString or other methods can often be called to serialize the parameter list for logging. This toString() call and methods it calls should not in turn cause tracing.

I propose setting this suppression on always, without option to disable it because I see no use-case where 'tracing while tracing' makes sense.

@snorbi07
Copy link
Contributor

snorbi07 commented Oct 2, 2017

Hi @kuzuk,
This is definitely a bug, so I agree that it needs to be the "default" behavior. The issue #44 will improve the situation of this as well.
This might be more of an issue with the tracer runtime (https://github.com/GoodGrind/ghostwriter-tracer) though. Anyways, I have to analyze how to tackle this the best way. Currently, at compile time we don't know whether a method call leads to already "traced" code or not.

@snorbi07 snorbi07 added the bug label Oct 2, 2017
@snorbi07 snorbi07 added this to the v0.7.0 milestone Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants