Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown to view non-median runs in diff view #235

Open
patrickhulce opened this issue Mar 4, 2020 · 2 comments
Open

Dropdown to view non-median runs in diff view #235

patrickhulce opened this issue Mar 4, 2020 · 2 comments
Labels
enhancement New feature or request P3

Comments

@patrickhulce
Copy link
Collaborator

We can't link to builds from the dashboard distribution view because we don't support any run that wasn't the median one. If we added UI support to view any run from that build we could support this.

Problem: even if we had the run available we wouldn't know from the statistic alone which run to link to 🤔 needs to be worked out.

@patrickhulce patrickhulce added enhancement New feature or request P3 labels Mar 4, 2020
@jflayhart
Copy link
Contributor

jflayhart commented Jun 16, 2020

@patrickhulce just curious if this is along the same lines of a slight data discrepancy I noticed in github checks (which is fine for now as long as it passes :P).

For example, lhci/url/search seems to link to the last report for that run, out of 5 runs:

lhci/url/search Performance Scores:
65/61/60/58/58

My threshold for this perf score is >=0.6, where the above median score is 60; so we're good, but this is what is shown:

Screen Shot 2020-06-16 at 11 54 43 AM

It shows 58 which is a failing score, but since the median score passes, it is OK. So is it possible to only surface the link to the median score's report? Example, 65/61/60/58/58 instead of the above result.

@patrickhulce
Copy link
Collaborator Author

Ah nice find @jflayhart! That is a bug with the description generation used when --target=lhci 👍

I'll file a separate bug for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3
Projects
None yet
Development

No branches or pull requests

2 participants