Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP_PROXY and HTTPS_PROXY not being respected by isomorphic-fetch [PSI Strategy] #748

Open
abhisheksoni27 opened this issue Jan 28, 2022 · 1 comment

Comments

@abhisheksoni27
Copy link

Describe the bug
A clear and concise description of what the bug is.

I am using lhci server behind a webproxy (corporate) and am unable to use the PSI strategy. The request keeps timing out. I suppose it is happening because:

const response = await this._fetch(url.href);

Here's another issue (matthew-andrews/isomorphic-fetch#171) that outlines that isomorphic-fetch does have this problem and it doesn't automatically read HTTP_PROXY and HTTPS_PROXY variables from env.

In that issue, this is also referenced: outline/outline#1893

In this issue, they fixed it here by removing isomorphic-fetch and adding https://github.com/outline/outline/pull/2044/files.

Can we do this here as well?

Environment (please complete the following information):

  • Version - latest
@abhisheksoni27
Copy link
Author

Here's the fix: #749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant