-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report generated time is always in en-US #1703
Comments
Aye. Confirming that in https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/report/v2/renderer/util.js we always render it in en-us, though we do use the local timezone. It started here #206 (comment) AFAIK there isn't a reason why we force en-us. We should leave it as undefined to pick up the local locale. |
We can now run lighthouse for your locale by using the locale option in the cli.
@paulirish we could enable multi locale support on lighthouse-viewer so people can override the defined locale. WDYT? |
We now default the renderer to 'en' otherwise read from config settings afaik. +1 to letting the viewer detect if there is a diff in report locale and local locale and give a conversion option maybe? Or the choice of locale? |
Yeah, confirmed that with the explicit I added bullet points to the i18n umbrella bug #7238 for being able to swap the locale in the viewer and investigate looking at system info for determining the locale to use automatically. |
Yet the date in the reports is always in English US format.
I find it confusing being that I'm not used to the US date format.
The text was updated successfully, but these errors were encountered: