Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-G/-A doesn't preserve gatherer errors #4984

Closed
brendankenny opened this issue Apr 17, 2018 · 0 comments · Fixed by #9397
Closed

-G/-A doesn't preserve gatherer errors #4984

brendankenny opened this issue Apr 17, 2018 · 0 comments · Fixed by #9397
Assignees

Comments

@brendankenny
Copy link
Member

brendankenny commented Apr 17, 2018

Internally they're real Errors, so they get serialized as {} :( This will obviously be an issue as errors won't show up in the -A stage. Presumably there will still be errors when audits try to use those artifacts, just not the ones you'd want to tell what's going on.

It would be nice to continue to use real Errors, so we should support saving and restoring errors in asset-saver if possible.

See skipped test TODO in runner-test.js which needs this in order to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants