Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offscreen-images: fallback to eotrace if there's no TTI #5955

Closed
paulirish opened this issue Sep 4, 2018 · 0 comments · Fixed by #6039
Closed

offscreen-images: fallback to eotrace if there's no TTI #5955

paulirish opened this issue Sep 4, 2018 · 0 comments · Fixed by #6039
Assignees
@exterkamp
Labels
P1.5

Comments

@paulirish
Copy link
Member

if there's no TTI (which is not fatal), then offscreen-images audit will just fail. instead we can fallback to use the end of trace timestamp. We also supply a warning in the report to say this.

An alternative to doing this is to just really suggest they re-run to get working TTI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@exterkamp exterkamp

Labels
P1.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: make offscreen-images audit work without TTI GoogleChrome/lighthouse
3 participants
@paulirish @brendankenny @exterkamp