docs: Consolidate all R2DBC docs onto one page. #1606
Conversation
hessjcg
changed the title
hessjcg
changed the title
hessjcg
force-pushed
the
gh-1550-r2dbc-docs
branch
from
509efcc to
fb85f2b
Compare
docs/r2dbc.md
Outdated
| .option(DRIVER, "gcp") | ||
| .option(PROTOCOL, "mysql") | ||
| .option(PASSWORD, "password") | ||
| .option(USER, "[email protected]") |
There was a problem hiding this comment.
Could we make these users service account users? In MySQL, everything after the @ sign is truncated. In postgres it's just [email protected] (and no .gserviceaccount.com)
There was a problem hiding this comment.
Ditto below under impersonation.
There was a problem hiding this comment.
This is sounding more like a rewrite of the IAM and Service Account Impersonation docs. Do we want to put that in a separate PR and make r2dbc.md and jdbc.md match?
docs/r2dbc.md
Outdated
| .option(DRIVER, "gcp") | ||
| .option(PROTOCOL, "mysql") | ||
| .option(PASSWORD, "password") | ||
| .option(USER, "[email protected]") |
There was a problem hiding this comment.
This user name needs to be a native user or be a correctly formatted IAM user.
docs/r2dbc.md
Outdated
| .option(DRIVER, "gcp") | ||
| .option(PROTOCOL, "postgresql") | ||
| .option(PASSWORD, "password") | ||
| .option(USER, "[email protected]") |
There was a problem hiding this comment.
Let's use a service account example instead of a human user.
| roles/iam.serviceAccounts.serviceAccountTokenCreator. | ||
|
|
||
| #### Mysql | ||
|
|
There was a problem hiding this comment.
Could MySQL and Postgres be combined with comments calling out differences?
hessjcg
force-pushed
the
gh-1550-r2dbc-docs
branch
from
fb85f2b to
ff03d7d
Compare
hessjcg
force-pushed
the
gh-1550-r2dbc-docs
branch
from
ff03d7d to
6f05943
Compare
Consolidate all R2DBC docs into a single page for easier maintenance.
Part of #1550