fix: remove default fallback when target function does not exist #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethgeorge
force-pushed
the
no-func-fallback
branch
from
c05e7fb to
79ba9fb
Compare
anniefu
reviewed
Jan 3, 2023
anniefu
approved these changes
Jan 3, 2023
anniefu
suggested changes
Jan 3, 2023
There was a problem hiding this comment.
Actually, I'm not sure we want to release this as a breaking change. I think it's just a small bug fix rather than an API change and doesn't really warrant a major version increment.
Could you change the commit description to just fix:?
https://github.com/googleapis/release-please#how-should-i-write-my-commits
garethgeorge
changed the title
Functions framework will no longer load a default function named 'function' if one is exported and the configured target can not be found. This behavior is unexpected and inconsistent with other function framework implementations.
garethgeorge
force-pushed
the
no-func-fallback
branch
from
79ba9fb to
0b8d586
Compare
|
Done, I wasn't sure if we might want to prevent users from updating to the new behavior. I suspect very few customers are depending on this behavior as it is not part of the contract & is not very expected. |
anniefu
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function framework's current behavior is to load an exported function named 'function' if one exists as a fallback if the user's declared target function is not found. This behavior is counter intuitive and can hide misconfiguration from the user.
In this CL a breaking change is made to disable this fallback behavior in favor of failing fast so that the configuration error is highly visible to the user.