fix: module resolution returns early and accurate error messages on failure #534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing module resolution logic has two logic errors which create a confusing experience when the customer's module isn't found:
null
is never returned even when the module is not found, this means function framework doesn't early return with an exception when it should if the function does not exist./function.js
prefix which gets incorporated as a side effect of the implementation today.This change simplifies the function and cleans up these errors.