_PerformStreamUpload passes Key where fp expected

[jterrace]

Original author: [email protected] (November 30, 2011 00:55:15)

The _PerformStreamUpload call at the end of _CopyObjToObjDiffProvider (in gslib/commands/cp.py) passes in a Key for the first param (where an fp is expected), which only works because of Python "duck typing" (the fact that the lower-level methods that expect an fp only happen to call fp methods that are defined and semantically equivalent to those defined on src_key). This should be replaced by a class that warps an fp interface around the Key, throwing 'not implemented' for methods (like seek) that aren't implemented by non-file Keys.

Original issue: http://code.google.com/p/gsutil/issues/detail?id=73

[jterrace]

From [email protected] on July 28, 2012 19:37:04
Due to changes in boto that now call fp-specific functions (like tell() and seek()) this duck-typing luckiness no longer suffices. This bug now blocks uses from doing cross-provider copies into gs://

Changing this to high priority.

[jterrace]

From [email protected] on August 12, 2012 23:39:28
Fixed in gsutil 3.15