Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span attributes for library name and version #332

Closed
dashpole opened this issue Mar 10, 2022 · 3 comments · Fixed by #365
Closed

Add span attributes for library name and version #332

dashpole opened this issue Mar 10, 2022 · 3 comments · Fixed by #365
Labels

Comments

@dashpole
Copy link
Contributor

Based on our exporter spec, they should be added as otel.instrumentation_library.name and otel.instrumentation_library.version. Although, I believe that plan should be altered by open-telemetry/opentelemetry-specification#2276, which changed them to suggest otel.scope.name and otel.scope.version.

@dashpole dashpole added the trace label Mar 10, 2022
@aabmass
Copy link
Contributor

aabmass commented Mar 10, 2022

For the collector metrics exporter, we are doing instrumentation_source and instrumentation_version (for telemetry attribution). Should we do the same for traces?

@dashpole
Copy link
Contributor Author

@dashpole
Copy link
Contributor Author

Ah, I forgot, we should use instrumentation_source and instrumentation_version to match metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants