Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix generating BQ views for IDC dataset #324

Merged
merged 1 commit into from
Apr 5, 2022
Merged

fix: Fix generating BQ views for IDC dataset #324

merged 1 commit into from
Apr 5, 2022

Conversation

adlersantos
Copy link
Member

@adlersantos adlersantos commented Apr 1, 2022 •
edited
Loading

Description

Fixes a bug for the IDC dataset where the generated BQ views should use the bigquery-public-data project .

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a feature
    • I have updated the README accordingly
    • I have added tests for the feature
  • I'm adding or editing a dataset
    • The Google Cloud Datasets team is aware of the proposed dataset
    • I put all my code inside datasets/<DATASET_NAME> and nothing outside of that directory
  • I'm adding/editing documentation
  • I'm submitting a bugfix
    • I have added tests to my bugfix (see the tests folder)
  • I'm refactoring or cleaning up some code

@adlersantos adlersantos added bug Something isn't working or open a bugfix revision: pipeline Revise a pipeline or dataset data onboarding Onboard a dataset or submit a pipeline labels Apr 1, 2022
@adlersantos adlersantos merged commit 5896865 into main Apr 5, 2022
@adlersantos adlersantos deleted the idc-bq-views-fix branch April 5, 2022 16:17
@release-please release-please bot mentioned this pull request Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happyhuman happyhuman happyhuman approved these changes

Assignees
No one assigned
Labels
bug Something isn't working or open a bugfix data onboarding Onboard a dataset or submit a pipeline revision: pipeline Revise a pipeline or dataset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adlersantos @happyhuman