Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixing the forecasting issue in the notebook. #472

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Conversation

happyhuman
Copy link
Contributor

@happyhuman happyhuman commented Sep 7, 2022

Description

Note: If you are adding or editing a dataset, please specify the dataset folder involved, e.g. datasets/google_trends

Checklist

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved

Use the sections below based on what's applicable to your PR and delete the rest:

Feature

  • I'm adding or editing a feature
  • I have updated the README accordingly
  • I have added/revised tests for the feature

Data Onboarding

  • I'm adding or editing a dataset
  • The Google Cloud Datasets team is aware of the proposed dataset
  • I put all my code inside datasets/<DATASET_NAME> and nothing outside of that directory

Documentation

  • I'm adding/editing documentation

Bug fix

  • I'm submitting a bugfix
  • I have added/revised tests related to my bugfix (see the tests folder)

Code cleanup or refactoring

  • I'm refactoring or cleaning up some code

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Sep 7, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@adlersantos adlersantos merged commit de7f1fa into main Sep 9, 2022
@adlersantos adlersantos deleted the sf_311_fix branch September 9, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants