Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Migrate the World Bank datasets x 3 from Xenon #506

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Feat: Migrate the World Bank datasets x 3 from Xenon #506

merged 5 commits into from
Oct 17, 2022

Conversation

Naveen130
Copy link
Contributor

@Naveen130 Naveen130 commented Oct 10, 2022 •
edited
Loading

Description

This PR makes changes to these 3 existing datasets

  • world_bank_health_population
  • world_bank_intl_debt
  • world_bank_intl_education

Checklist

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved

Code cleanup or refactoring

  • I'm refactoring or cleaning up some code

@Naveen130 Naveen130 self-assigned this Oct 10, 2022
@Naveen130
Copy link
Contributor Author

@nlarge-google As discussed, I have made the changes in a single PR for the remaining World Bank datasets.

nlarge-google
nlarge-google requested changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@nlarge-google nlarge-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes necessary. Great job though!

datasets/world_bank_health_population/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
datasets/world_bank_health_population/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
datasets/world_bank_health_population/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
datasets/world_bank_health_population/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
datasets/world_bank_health_population/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
datasets/world_bank_health_population/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
datasets/world_bank_health_population/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
datasets/world_bank_health_population/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated Show resolved Hide resolved
@Naveen130
Copy link
Contributor Author

@nlarge-google I have taken care of your comments. You may review.

nlarge-google
nlarge-google approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@nlarge-google nlarge-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@nlarge-google nlarge-google merged commit 65295d0 into GoogleCloudPlatform:main Oct 17, 2022
@release-please release-please bot mentioned this pull request Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlarge-google nlarge-google nlarge-google approved these changes

@adlersantos adlersantos Awaiting requested review from adlersantos

Assignees

@Naveen130 Naveen130

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naveen130 @nlarge-google