Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s390x kaniko build to multi-arch list #1475

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

barthy1
Copy link
Contributor

@barthy1 barthy1 commented Oct 30, 2020

Description

This is extension of current code to build s390x version of kaniko executor image and add it to multi-arch manifest.

Unfortunately at this moment integration tests cannot be added to this PR, as bazel binary is not publicly available for s390x. Tests on my local s390x environment using https://github.com/GoogleContainerTools/kaniko/blob/master/.travis.yml#L50-L57 are PASSED

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

The executor:multi-arch image now supports 3 architectures amd64, arm64 and s390x.

This is extenion of current code to build s390x version of kaniko
executor image and add it to multi-arch manifest

Signed-off-by: Yulia Gaponenko <[email protected]>
@google-cla google-cla bot added the cla: yes CLA signed by all commit authors label Oct 30, 2020
@tejal29
Copy link
Contributor

tejal29 commented Nov 3, 2020

@barthy1 would you to also add s390x to the debug image?

@barthy1
Copy link
Contributor Author

barthy1 commented Nov 4, 2020

@tejal29

would you to also add s390x to the debug image?

At this moment debug image is not multi-arch at all. I'd suggest to have separate PR for that.

@tejal29 tejal29 merged commit 49e7d8a into GoogleContainerTools:master Nov 4, 2020
@tejal29
Copy link
Contributor

tejal29 commented Nov 4, 2020

@tejal29 to follow up the s390x image from master for @barthy1 to test.

@tejal29
Copy link
Contributor

tejal29 commented Nov 4, 2020

@barthy1 Please verify if this image works as expected.
gcr.io/kaniko-project/executor:s390x-49e7d8a8cd2e0f071881afa8f3a9d3935e9f7103

@barthy1
Copy link
Contributor Author

barthy1 commented Nov 5, 2020

@tejal29 I verified that image is runnable on s390x architecture and also verified that executor binary works as expected.

@tejal29
Copy link
Contributor

tejal29 commented Nov 5, 2020

Thanks. The next release is scheduled before Thanks giving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants