Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for skaffold diagnose #2465

Closed
corneliusweig opened this issue Jul 13, 2019 · 3 comments
Closed

Improve documentation for skaffold diagnose #2465

corneliusweig opened this issue Jul 13, 2019 · 3 comments
Labels
area/config area/docs kind/documentation kind/todo implementation task/epic for the skaffold team

Comments

@corneliusweig
Copy link
Contributor

corneliusweig commented Jul 13, 2019

When working with Skaffold profiles, it would be illustrative to see what the effective skaffold.yaml is that Skaffold works with. AFAIK Skaffold does currently not support this, but I think this is quite important for debugging.

For example, skaffold fix could have a --flatten mode and accept a list of profiles to show the effective yaml. WDYT?

EDIT It turns out, skaffold diagnose already does that. Therefore I relabeled the issue to improve the diagnose docs.

@corneliusweig corneliusweig changed the title Provide mechanism to show the effective skaffold.yaml Provide mechanism to show the effective skaffold.yaml when working with profiles Jul 13, 2019
@dgageot
Copy link
Contributor

dgageot commented Jul 13, 2019

@corneliusweig I think skaffold diagnose does that

@corneliusweig
Copy link
Contributor Author

corneliusweig commented Jul 13, 2019

@dgageot woops, you are right! Didn't know that. Thanks for nudging me in the right direction.

What do you think about mentioning this in the short description of skaffold diagnose? At the moment it just says

Run a diagnostic on Skaffold

Maybe something like

Run diagnostics on Skaffold and print the effective config

Additionally, it could get a long description.

@corneliusweig corneliusweig changed the title Provide mechanism to show the effective skaffold.yaml when working with profiles Improve documentation for skaffold diagnose Jul 15, 2019
@balopat balopat added kind/documentation priority/p2 May take a couple of releases and removed kind/feature-request labels Sep 24, 2019
@tejal29 tejal29 added priority/p0 Highest priority. We are actively looking at delivering it. kind/todo implementation task/epic for the skaffold team and removed priority/p2 May take a couple of releases labels Oct 9, 2019
@tejal29 tejal29 mentioned this issue Oct 9, 2019
8 tasks
@tejal29 tejal29 removed the priority/p0 Highest priority. We are actively looking at delivering it. label Nov 6, 2019
@tstromberg
Copy link
Contributor

I'm closing this issue as it hasn't seen activity in awhile, and it's unclear if this issue still exists. If this issue does continue to exist in the most recent release of Skaffold, please feel free to add a comment and we'll re-open it.

If someone sees a similar issue, please create a new issue, but do include a link to this issue if possible.

Thank you for opening the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/docs kind/documentation kind/todo implementation task/epic for the skaffold team
Projects
None yet
Development

No branches or pull requests

5 participants