Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not patch empty values #3446

Closed
kvokka opened this issue Dec 24, 2019 · 1 comment
Closed

can not patch empty values #3446

kvokka opened this issue Dec 24, 2019 · 1 comment

Comments

@kvokka
Copy link

kvokka commented Dec 24, 2019

if I leave the build section empty for further addition in the profiles with patches, like:

apiVersion: skaffold/v2alpha1
kind: Config
build:
  artifacts: []
deploy:
  helm:
    releases: []

and then apply any profile:

profiles:
- name: pubsub_emulator
  patches:
  - op: add
    path: /build/artifacts/-
    value:
      image: us.gcr.io/replay-gaming/pubsub-emulator
      docker:
        dockerfile: support/skaffold/pubsub_emulator/Dockerfile
  - op: add
    path: /deploy/kubectl/manifests/-
    value: support/skaffold/pubsub_emulator/k8s.yaml

Expected behavior

no error

Actual behavior

I can not use patches

$ skaffold build -p api
FATA[0000] creating runner: applying profiles: applying profile api: invalid path: /build

Information

  • Skaffold version: version 1.1.0
  • Operating system: MacOs 10.15.2

Connect #3277

@nkubala
Copy link
Contributor

nkubala commented Jan 8, 2020

hey @kvokka, thanks for the issue. I debugged this very issue in relation to #2741 earlier today, check out my response there for details on this one. I'll close this as a dupe, you can keep tracking there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants