Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skaffold keeps rebuilding and redeploying a helm chart with dependencies #3565

Closed
petarManolov opened this issue Jan 23, 2020 · 5 comments · Fixed by #4181
Closed

Skaffold keeps rebuilding and redeploying a helm chart with dependencies #3565

petarManolov opened this issue Jan 23, 2020 · 5 comments · Fixed by #4181
Assignees
Labels
area/deploy area/watch deploy/helm fixit kind/bug Something isn't working needs-reproduction needs reproduction from the maintainers to validate the issue is truly a skaffold bug priority/p2 May take a couple of releases

Comments

@petarManolov
Copy link

petarManolov commented Jan 23, 2020

Expected behavior

After running skaffold dev and the initial build and deployment is done, it will only trigger a new build / deploy when I make a change to the source or helm charts.

Actual behavior

After the initial build, the chart is continuously re-deployed in a loop.

Information

  • Skaffold version: v1.2.0
  • Operating system: Ubuntu 19.10 / macOS 10.15
  • Project Info : Java based project build with maven
  • Possible regressions: issues-931 and/or issues-667
  • Contents of skaffold.yaml:
apiVersion: skaffold/v2alpha2
kind: Config
build:
  tagPolicy:
    sha256: {}
  artifacts:
    - image: dps
      context: .
      docker:
        dockerfile: Dockerfile
  local:
    useDockerCLI: true
deploy:
  helm:
    releases:
      - name: dps
        chartPath: helm/dps
        namespace: sandbox-dataplatform
        setValueTemplates:
          val1: "{{ .ENV_VAL_1 }}"
          val2: "{{ .ENV_VAL_2 }}"
        values:
           container.image: dps
  • Project Structure
.circleci
checkstyle
db
helm
  dps
    values.yml
    ....
src
  main
  test
pom.xml
Dockerfile
entrypoint.sh
pom.xml
skaffold.yaml
  • Docker File
FROM openjdk:11.0-jre

LABEL maintainer="[email protected]"
LABEL maintainer_team='[email protected]'

ARG APP_LOCATION=/usr/local/myapp

ADD ./target/myapp.jar $APP_LOCATION/myapp.jar
ADD ./entrypoint.sh $APP_LOCATION/entrypoint.sh
RUN chmod u+x $APP_LOCATION/entrypoint.sh

EXPOSE 80/tcp

ENTRYPOINT ["/usr/local/myapp/entrypoint.sh"]


Steps to reproduce the behavior

  1. skaffold dev --trigger notify
@balopat balopat added deploy/helm kind/bug Something isn't working priority/p1 High impact feature/bug. priority/p2 May take a couple of releases area/deploy area/watch and removed priority/p1 High impact feature/bug. labels Jan 27, 2020
@balopat
Copy link
Contributor

balopat commented Jan 27, 2020

Hi @petarManolov, thanks for the issue, can you share your Dockerfile contents as well? Thanks!

@hanzketup
Copy link

Facing the same issue, skaffold is picking up changes to the chart dependencies:
INFO[0041] files modified: [project/chart/charts/postgresql-8.1.5.tgz]

Adding */charts/ to my .dockerignore fixes the issue though.

@petarManolov
Copy link
Author

HI @balopat I've updated the original issue with my docker file contents.

@nkubala
Copy link
Contributor

nkubala commented Apr 24, 2020

hey @petarManolov I'd like to try to dig into this one but I'm not sure how to reproduce. would you maybe be able to provide a small sample project in a repo that I can clone and run on?

@dgageot dgageot added the needs-reproduction needs reproduction from the maintainers to validate the issue is truly a skaffold bug label Apr 28, 2020
@balopat balopat added the fixit label May 4, 2020
@gsquared94 gsquared94 self-assigned this May 12, 2020
@tstromberg
Copy link
Contributor

Closing because we haven't heard back. Please comment when you get a chance to update this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deploy area/watch deploy/helm fixit kind/bug Something isn't working needs-reproduction needs reproduction from the maintainers to validate the issue is truly a skaffold bug priority/p2 May take a couple of releases
Projects
None yet
7 participants