Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running skaffold in debug mode shows watching for changes #4653

Closed
etanshaul opened this issue Aug 12, 2020 · 2 comments · Fixed by #4676
Closed

Running skaffold in debug mode shows watching for changes #4653

etanshaul opened this issue Aug 12, 2020 · 2 comments · Fixed by #4676
Assignees
Labels
area/debug area/watch kind/friction Issues causing user pain that do not have a workaround priority/p1 High impact feature/bug.

Comments

@etanshaul
Copy link
Contributor

Watch mode is disabled for debugging. So this is an incorrect message.

skaffold debug --filename skaffold.yaml --default-repo gcr.io/etan-gcp --rpc-port 50051 --port-forward=true --enable-rpc=true
Listing files to watch...
 - java-hello-world
Generating tags...
 - java-hello-world -> gcr.io/etan-gcp/java-hello-world:latest
Checking cache...
 - java-hello-world: Found Locally
Tags used in deployment:
 - java-hello-world -> gcr.io/etan-gcp/java-hello-world:26dd58e67e1125ec7bfea12c6234c542d7b0efe3b0fc89aee072b2e97c54caf8
Starting deploy...
 - deployment.apps/java-hello-world created
 - service/java-hello-world-external created
Waiting for deployments to stabilize...
 - deployment/java-hello-world: waiting for rollout to finish: 0 of 1 updated replicas are available...
    - pod/java-hello-world-565f447966-2xmtq: creating container server
 - deployment/java-hello-world is ready.
Deployments stabilized in 1.37981394s
Port forwarding service/java-hello-world-external in namespace default, remote port 80 -> address 127.0.0.1 port 4503
Press Ctrl+C to exit
Watching for changes...
@etanshaul
Copy link
Contributor Author

@russwolf fyi. you were right about this.

@briandealwis briandealwis added area/debug area/watch kind/friction Issues causing user pain that do not have a workaround priority/p1 High impact feature/bug. labels Aug 12, 2020
@gsquared94
Copy link
Contributor

Skaffold has a file watcher that aggregates file changes; build, sync and deploy either auto fire or fire on trigger from the API and take appropriate action on the accumulated file changes. In case of debug even though the auto build and auto deploy triggers are turned off, the file watcher continues monitoring the file system. That file watcher prints this Watching for changes message. But to the user it seems to suggest auto build/sync/deploy. I'll try to make the distinction more obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment