Disabling profiles does not work

[vladimir-avinkin]

Expected behavior

According to documentation (in skaffold --help) prepending a minus sign before a profile name should disable it, instead, we get an error.

Actual behavior

When trying to disable a profile we get an error that says that a profile with a prepended minus is not declared.

Information

• Skaffold version: v1.35.2
• Operating system: Darwin MacBook-Pro-Vladimir.local 20.3.0 Darwin Kernel Version 20.3.0: Thu Jan 21 00:07:06 PST 2021; root:xnu-7195.81.3~1/RELEASE_X86_64 x86_64
• Installed via: homebrew
• Contents of skaffold.yaml:

apiVersion: skaffold/v2beta13
kind: Config
profiles:
  - name: default
  - name: test

Below are my speculations:
The initial feature was introduced here #4054 and then probably the logic got duplicated somewhere along the way, probably two places that conflict with each other are here:

skaffold/pkg/skaffold/parser/config.go

Line 96 in 20ae7f6

return nil, sErrors.ConfigProfilesNotMatchedErr(unmatched)

skaffold/pkg/skaffold/schema/profiles.go

Line 130 in 20ae7f6

activated = removeValue(activated, strings.TrimPrefix(profile, "-"))

Steps to reproduce the behavior

1. bare skaffold.yaml contents of which are stated above is enough to reproduce
2. skaffold dev -p -test
3. According to documentation prepending a minus sign before a profile name should disable it, instead we got an error

skaffold dev -p -test
parsing skaffold config: profile selection ["-test"] did not match those defined in any configurations. Check that values specified in the "--profile" or "-p" flags are valid profile names.

[tomasmota]

I'll take a look at this :)