Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move buildpacks tutorial to buildpacks example README #2908

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

priyawadhwa
Copy link
Contributor

@priyawadhwa priyawadhwa commented Sep 18, 2019

Addresses feedback from @balopat 's comment

@tejal29
Copy link
Member

tejal29 commented Sep 18, 2019

Failed due to test flake #2906, fix #2907

@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Sep 19, 2019
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@container-tools-bot
Copy link

Please visit http://34.94.233.95:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Sep 19, 2019
@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #2908 into master will not change coverage.
The diff coverage is n/a.

@priyawadhwa priyawadhwa merged commit cda4c29 into GoogleContainerTools:master Sep 19, 2019
@priyawadhwa priyawadhwa deleted the bp-tutorial branch September 19, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants