-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kpt Deployer Dependencies() implementation and tests #4696
Kpt Deployer Dependencies() implementation and tests #4696
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4696 +/- ##
==========================================
+ Coverage 73.20% 73.24% +0.04%
==========================================
Files 340 340
Lines 13400 13424 +24
==========================================
+ Hits 9809 9832 +23
Misses 2982 2982
- Partials 609 610 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minors. Overall LGTM.
Related: #3904
Description
This is the implementation and unit tests for the dependencies method of the kpt deployer. Dependencies include the functions being ran, the files used by those functions, and kustomizations. It is important to note here that the applyDir (see #4691) is not set as a dependency.