Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kpt Deployer Dependencies() implementation and tests #4696

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Kpt Deployer Dependencies() implementation and tests #4696

merged 2 commits into from
Aug 19, 2020

Conversation

felixtran39
Copy link
Contributor

@felixtran39 felixtran39 commented Aug 18, 2020

Related: #3904

Description
This is the implementation and unit tests for the dependencies method of the kpt deployer. Dependencies include the functions being ran, the files used by those functions, and kustomizations. It is important to note here that the applyDir (see #4691) is not set as a dependency.

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #4696 into master will increase coverage by 0.04%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4696      +/-   ##
==========================================
+ Coverage   73.20%   73.24%   +0.04%     
==========================================
  Files         340      340              
  Lines       13400    13424      +24     
==========================================
+ Hits         9809     9832      +23     
  Misses       2982     2982              
- Partials      609      610       +1     
Impacted Files Coverage Δ
pkg/skaffold/deploy/kpt.go 87.09% <84.00%> (-2.38%) ⬇️
pkg/skaffold/deploy/kustomize.go 79.64% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f665e...ab07635. Read the comment docs.

pkg/skaffold/deploy/kpt.go Outdated Show resolved Hide resolved
Copy link
Contributor

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minors. Overall LGTM.

@felixtran39 felixtran39 added the kokoro:run runs the kokoro jobs on a PR label Aug 18, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Aug 18, 2020
@MarlonGamez MarlonGamez merged commit 079662d into GoogleContainerTools:master Aug 19, 2020
@felixtran39 felixtran39 deleted the dependencies branch August 19, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants