Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement initial infrastructure for the Spline tool to join itself with other splines and paths #2269

Merged

Conversation

Sidharth-Singh10
Copy link
Contributor

@Sidharth-Singh10 Sidharth-Singh10 commented Feb 6, 2025

Closes #2184 (part of part 4)

@Keavon
Copy link
Member

Keavon commented Feb 7, 2025

!build

Copy link

github-actions bot commented Feb 7, 2025

📦 Build Complete for 3975f74
https://036d67b9.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Feb 7, 2025

Seems like this breaks if I try to connect a spline to a line (drawn with the Line tool). There are two modes for failure:

  1. Start with a line, then draw the spline and end with connecting to an endpoint of the line. They don't connect together.
  2. Start with a line and a spline, then use the Spline tool to extend the spline into the line. The line disappears to the top left of the artboard with a straight line connector going to that origin corner.

@Keavon
Copy link
Member

Keavon commented Feb 13, 2025

!build

Copy link

📦 Build Complete for f9fdc28
https://021d0642.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Feb 13, 2025

Merging with known issue in my case #2 described above being more broken than before (invalidating the graph).

@Keavon Keavon marked this pull request as ready for review February 13, 2025 10:40
@Keavon Keavon changed the title Merge Layers with Spline Tool Implement initial infrastructure for the Spline tool to join itself with other splines and paths Feb 13, 2025
@Keavon Keavon merged commit e44c460 into GraphiteEditor:master Feb 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the Spline tool draw a polylines with a Path -> Spline from Points node setup
2 participants