Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement home animals #2329

Merged
merged 2 commits into from
Sep 2, 2023
Merged

feat: implement home animals #2329

merged 2 commits into from
Sep 2, 2023

Conversation

hamusuke0323
Copy link
Contributor

Description

implements home animals.

Issues fixed by this PR

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

image

@KingRainbow44 KingRainbow44 merged commit 97138d8 into Grasscutters:development Sep 2, 2023
1 of 2 checks passed
@hamusuke0323 hamusuke0323 deleted the potanimals branch September 2, 2023 09:30
@pfyy
Copy link
Contributor

pfyy commented Sep 4, 2023

please add HomeWorldNPCExcelConfigData.json and HomeworldAnimalExcelConfigData.json to the popularly used gc resources repo on gitlab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamusuke0323 @pfyy @KingRainbow44