Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode.uri.file is not a constructor - The Journal window fails to load anything #11

Closed
brianmccarty opened this issue Feb 26, 2019 · 4 comments
Assignees
Labels
bug Something isn't working fixed

Comments

@brianmccarty
Copy link

Running:

Version: 1.32.0-insider (system setup)
Commit: 7d0c9e6fa0bedcf71bdae86c02611b65362795a3
Date: 2019-02-26T06:19:00.351Z
Electron: 3.1.3
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763

vscode-journal-view 0.0.22

2019-02-26_09-18-25

notificationsAlerts.ts:38
Error: vscode.Uri.file is not a constructor
	at JournalDataProvider.getTreeItem (c:\Users\bmccarty\.vscode-insiders\extensions\gruntfuggly.vscode-journal-view-0.0.22\dataProvider.js:148:36)
	at define.fetchChildrenNodes.a.asPromise.then.Promise.all.u.coalesce.map.a.asPromise (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:441:138)
	at t.asPromise.Promise (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:48:58)
	at new Promise (<anonymous>)
	at Object.t.asPromise (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:48:32)
	at define.fetchChildrenNodes.a.asPromise.then.Promise.all.u.coalesce.map.e (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:441:106)
	at Array.map (<anonymous>)
	at define.fetchChildrenNodes.a.asPromise.then.e (c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:441:97)
@Gruntfuggly Gruntfuggly added duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists labels Feb 26, 2019
@Gruntfuggly Gruntfuggly self-assigned this Feb 26, 2019
@Gruntfuggly Gruntfuggly added the question Further information is requested label Feb 26, 2019
@Gruntfuggly
Copy link
Owner

This seems to be due to something changing in the API. I need to find out what is being changed as the current implementation is correct according to the documentation, and works as expected with the stable release of vscode.

@brianmccarty
Copy link
Author

I'm happy to test

@Gruntfuggly
Copy link
Owner

Fixed in the latest version.

@Gruntfuggly Gruntfuggly added bug Something isn't working fixed and removed question Further information is requested labels Feb 27, 2019
@brianmccarty
Copy link
Author

Indeed 0.0.23 fixed the issue. Thank you for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

2 participants