Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with other custom maker addons #4

Open
GuimDev opened this issue Jun 1, 2018 · 1 comment
Open

Compatibility with other custom maker addons #4

GuimDev opened this issue Jun 1, 2018 · 1 comment
Labels
Back office It is about the code / main function Compatibility Compatibility with other addon Evolution TF improvement Fundamental (GL) Guideline for the big improvement

Comments

@GuimDev
Copy link
Owner

GuimDev commented Jun 1, 2018

We need to make support for custom maker addons.

Addon like : Destinations, WaypointIt, TweakIt with specific point.

Example :

ZO_PreHookHandler(ZO_WorldMap, "OnShow", UpdateInventoryContent)
ZO_PreHookHandler(ZO_WorldMap, "OnHide", UpdateMapFilters)
EVENT_MANAGER:RegisterForEvent("Destinations", EVENT_POI_UPDATED, OnDestPOIUpdate)
EVENT_MANAGER:RegisterForEvent("Destinations", EVENT_PLAYER_ACTIVATED, UpdateMapFilters)
EVENT_MANAGER:RegisterForEvent("Destinations", EVENT_ACHIEVEMENT_UPDATED, OnAchievementUpdate)
EVENT_MANAGER:RegisterForEvent("Destinations", EVENT_QUEST_ADDED, RegisterQuest)
EVENT_MANAGER:RegisterForEvent("Destinations", EVENT_QUEST_OFFERED, RegisterNPC)
EVENT_MANAGER:RegisterForEvent("Destinations", EVENT_QUEST_COMPLETE, RegisterQuestDone)
EVENT_MANAGER:RegisterForEvent("Destinations", EVENT_QUEST_REMOVED, RegisterQuestCancelled)
EVENT_MANAGER:RegisterForEvent("Destinations", EVENT_GAMEPAD_PREFERRED_MODE_CHANGED, OnGamepadPreferredModeChanged)

How to do fix it :

  • Make folder "compatibility" and one file by addon.
  • Pop-up : "Do you want to enable the compatibility mode ? Yes ->Show custom marker".
  • Try ... catch ... ! No choice ! 10 issues => Stop loading the compatibility mode/functions. TF have to work if compatibility mode crash.

EDIT :

Simple way :

Add all icons which are in the compas !

@GuimDev GuimDev added Fundamental (GL) Guideline for the big improvement Evolution TF improvement Back office It is about the code / main function Compatibility Compatibility with other addon labels Jun 1, 2018
@GuimDev
Copy link
Owner Author

GuimDev commented Dec 21, 2018

Ref #36 & #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back office It is about the code / main function Compatibility Compatibility with other addon Evolution TF improvement Fundamental (GL) Guideline for the big improvement
Projects
None yet
Development

No branches or pull requests

1 participant