Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colormap event specifications #20

Merged
merged 1 commit into from
Feb 3, 2017
Merged

Colormap event specifications #20

merged 1 commit into from
Feb 3, 2017

Conversation

favreau
Copy link
Contributor

@favreau favreau commented Feb 2, 2017

No description provided.

This was referenced Feb 2, 2017
Copy link
Contributor

@tribal-tec tribal-tec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

the network representation into a OpenGL ready lookup table for creating a
texture.
- Represent extra material properties such as light emission, color contribution
and specular color.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more specular color

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, nobody was really convinced, so I removed it. I am OK to adding it back, no opinion there. We can always add it later if any of the renderers needs/wants it.


### Messages
A color maps cannot be partially updated, the message always describes the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As, not A?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, A is fine.

@chevtche
Copy link

chevtche commented Feb 2, 2017

+2

@favreau favreau force-pushed the master branch 2 times, most recently from f0a5490 to 6579c96 Compare February 2, 2017 12:36
@rdumusc rdumusc removed their request for review February 2, 2017 12:55
@favreau favreau merged commit 981b1bb into HBPVIS:master Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants