Move high-level classes for ClipPlanes and Histogram from Livre #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retest this please |
eile
reviewed
Feb 14, 2017
lexis/render/ClipPlanes.cpp
Outdated
| extent.z() * std::abs( plane.z( )); | ||
|
|
||
| if( !( d - n >= 0 || d + n > 0 )) | ||
| return true; |
There was a problem hiding this comment.
This code is (or should be) in vmmlib
eile
reviewed
Feb 14, 2017
lexis/render/ClipPlanes.h
Outdated
| LEXIS_API void reset(); | ||
|
|
||
| /** @return false if the clipping planes intersect or include the volume.*/ | ||
| LEXIS_API bool isClipped( const vmml::AABBf& box ) const; |
There was a problem hiding this comment.
bool isOutside? isClipped is the wrong name according to the doxygen.
eile
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.