-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Menu Highlighting Removed in #2172 #2178
Comments
Hi, I am new to helping out on Open Source project and spoke with the .NetRocks guys at Progressive.Net and they said find an issue and dive in so here I am. Happy to start with this one as it looks simple enough and learn the ropes from there. Have forked the project and looking over the code while I await a reply. Cliff. |
@CliffAgius That's great. Go for it and let us know if you have any questions or issues. Are you on the slack channel? |
@CliffAgius I started to look into this issue, and I found this blog post that might be helpful. Thought I'd pass it along. |
@jonparker I am not on the slack channel any chance of an invite please @MisterJames @dylanwooters did you get anywhere other than research I don't want to step on anyone's toes or repeat any work that may already have been done. |
@CliffAgius I didn't get any farther than research. Feel free to take it! I'll grab another one. |
@jonparker @dylanwooters Ok so I have finally found some time (Work sim check got in the way!) and built the solution locally to have a good look around the project. The problem is that looking on my local build the menu highlighting is working so I can't see what the issue is and believe this should be closed unless I am missing something... |
@CliffAgius Do you have the latest copy of the master branch? I'm still seeing the issue. |
@CliffAgius and @stevejgordon I just logged into http://allready-d.azurewebsites.net/ and the current page is not highlighted in the menu. Screenshots for chrome and firefox: https://imgur.com/a/Rlfv9 |
@CliffAgius If you still want to grab this and take a look, please do. Otherwise I can turn it over to our team at a codeathon we're hosting this weekend. |
Hi, I did some research on this and there's a tag helper you can create to add an active css class to the active link: https://benjii.me/2017/01/is-active-route-tag-helper-asp-net-mvc-core/ |
As I tested this issue on local and azurewebsite, issue looks to be fixed. |
Still seems to be an issue for me locally and on azure |
I implemented the solution @jonparker suggested. |
PR #2172 removed some highlighting functionality that should be restored, but with a more global scope to highlight any menu item with a matching route.
A highlight that does more to accent the current page would also be preferred (such as changing the background color).
The text was updated successfully, but these errors were encountered: