Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Menu Highlighting Removed in #2172 #2178

Open
MisterJames opened this issue Nov 14, 2017 · 13 comments · May be fixed by #2320
Open

Restore Menu Highlighting Removed in #2172 #2178

MisterJames opened this issue Nov 14, 2017 · 13 comments · May be fixed by #2320

Comments

@MisterJames
Copy link
Contributor

MisterJames commented Nov 14, 2017

PR #2172 removed some highlighting functionality that should be restored, but with a more global scope to highlight any menu item with a matching route.

image

A highlight that does more to accent the current page would also be preferred (such as changing the background color).

@CliffAgius
Copy link

Hi,

I am new to helping out on Open Source project and spoke with the .NetRocks guys at Progressive.Net and they said find an issue and dive in so here I am. Happy to start with this one as it looks simple enough and learn the ropes from there.

Have forked the project and looking over the code while I await a reply.

Cliff.

@jonparker
Copy link
Contributor

@CliffAgius That's great. Go for it and let us know if you have any questions or issues. Are you on the slack channel?
@MisterJames should be able to invite you.

@dylanwooters
Copy link

@CliffAgius I started to look into this issue, and I found this blog post that might be helpful. Thought I'd pass it along.

@CliffAgius
Copy link

@jonparker I am not on the slack channel any chance of an invite please @MisterJames

@dylanwooters did you get anywhere other than research I don't want to step on anyone's toes or repeat any work that may already have been done.

@dylanwooters
Copy link

@CliffAgius I didn't get any farther than research. Feel free to take it! I'll grab another one.

@CliffAgius
Copy link

@jonparker @dylanwooters Ok so I have finally found some time (Work sim check got in the way!) and built the solution locally to have a good look around the project. The problem is that looking on my local build the menu highlighting is working so I can't see what the issue is and believe this should be closed unless I am missing something...
2017-12-10_li

@stevejgordon
Copy link
Member

@CliffAgius Do you have the latest copy of the master branch? I'm still seeing the issue.

@jonparker
Copy link
Contributor

@CliffAgius and @stevejgordon I just logged into http://allready-d.azurewebsites.net/ and the current page is not highlighted in the menu. Screenshots for chrome and firefox: https://imgur.com/a/Rlfv9

@stevejgordon
Copy link
Member

@CliffAgius If you still want to grab this and take a look, please do. Otherwise I can turn it over to our team at a codeathon we're hosting this weekend.

@jonparker
Copy link
Contributor

Hi, I did some research on this and there's a tag helper you can create to add an active css class to the active link: https://benjii.me/2017/01/is-active-route-tag-helper-asp-net-mvc-core/

@manojattal
Copy link
Contributor

As I tested this issue on local and azurewebsite, issue looks to be fixed.

@stevejgordon
Copy link
Member

Still seems to be an issue for me locally and on azure

@mk0sojo mk0sojo linked a pull request May 12, 2018 that will close this issue
@mk0sojo
Copy link
Contributor

mk0sojo commented May 12, 2018

I implemented the solution @jonparker suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants